This repository was archived by the owner on May 14, 2020. It is now read-only.
omitted valueGetterFor Number nodetype (numeric values )#72
Open
kikonejacob wants to merge 2 commits intoalexkuz:masterfrom
Open
omitted valueGetterFor Number nodetype (numeric values )#72kikonejacob wants to merge 2 commits intoalexkuz:masterfrom
kikonejacob wants to merge 2 commits intoalexkuz:masterfrom
Conversation
Node items with numeric value are not rendered as the valueGetter function is not defined. This PR fix this issue by assigning a valueGetter function to nodetype of value "Number"
Owner
|
Can you provide an example of failing data? |
Author
|
The compomemt will fail at rendering "timeout" : 5000 [{
"type": "error",
"message": "Timeout: Unable to communicate with the parent App",
"params": {
"externalCommand": "userPreferences",
"timeout": 5000
}
}, {
"type": "error",
"message": "Unable to initialize WPF Handler",
"params": {}
}] |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Node items with numeric value are not rendered as the valueGetter function is not defined. This PR fix this issue by assigning a valueGetter function to nodetype of value "Number"