Conversation
xnorpx
reviewed
Aug 6, 2026
| @@ -0,0 +1,108 @@ | |||
| //! DTLS handshake run over ICE, inside STUN connectivity checks. | |||
Collaborator
There was a problem hiding this comment.
I would test all combination of this in
https://github.com/algesten/str0m/blob/main/tests/handshake-direct.rs
as well.
so dtls over ice
true, true
true, false
false, true
false, false
Collaborator
|
@pthatcher I pushed 2 extra commits that was needed. |
Owner
|
@pthatcher is this one ready for review or is it still Draft? |
Collaborator
@algesten It seems to work but we need to sync with fippo to ensure the different implementations are aligned. (libwebrtc/pion etc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.