Build time default network selection and custom network support#548
Build time default network selection and custom network support#548urtho wants to merge 1 commit into
Conversation
|
Hi @urtho, thanks for the PR. From my understanding, you are adding 2 features into lora:
May I ask why do you need the "custom network at build time" feature? Currently, lora supports custom network already. If you head to Lora settings, you can create one Additionally, I think supporting custom network at build time isn't flexible because:
I think the second feature "fee sink address for custom network" is very valuable. In the transaction wizard, currently we auto populate the sender address with the fee sink address, but only for testnet, fnet, betanet and localnet. Therefore, allowing this for custom network would give us a lot of flexibility. Do you want to update the existing Lora network settings feature to add fee sink address to custom network? |
|
Hi, thanks for taking a look at this PR. This is intended for private AVM networks that I run (think Algorand L2s ;) ) My wording is also incorrect, as the PR is not about build-time support. |

This PR adds support for a build time custom network definition (name, id, endpoints, feesink).
It also adds (optional) default network selection.