Stable TMPL_ byte sizes#717
Draft
iglosiggio wants to merge 3 commits into
Draft
Conversation
|
|
|
|
Checking stubs for changes and corresponding version bump in origin/iglosiggio/stable-tmpl-byte-size Last puyapy release: v5.8.1 ✅ Stub files unchanged |
| value >>= 7 | ||
| result = b"" | ||
| while value: | ||
| for i in range(0, 9): |
Contributor
There was a problem hiding this comment.
Should this be 10 bytes? If each byte can carry 7 bits then 7 * 9 is 63 bits, one short of 64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR modifies the way we generate bytecode so a statically-known amount of bytes is used whenever possible. For uint64 values this makes our constants bigger (unless
-O2is chosen).num_bytesproperty to the TemplateVar definition in both the MIR an TEAL layers_TemplateIntmarker class that allows the encoding layer to distinguish regular constants from template variable constantsTO-DO
_TemplateIntchange in a cleaner wayOutside scope