add range condition - #24
Open
XueSeason wants to merge 1 commit into
Open
Conversation
fengmk2
reviewed
Jun 5, 2017
| where: { | ||
| type: 'javascript' | ||
| type: 'javascript', | ||
| date: [{ op: '>=', value: '20170504'}] |
Member
There was a problem hiding this comment.
date: { op: '>=', value: '20170504'}这样会更好吧，可以参考一下业务关于 where 的 api 实现。
Member
There was a problem hiding this comment.
date >= 100 AND date <= 200 这种需求么？
Member
There was a problem hiding this comment.
最好也支持只传一个 object 的场景吧 date: { op: '>=', value: '20170504'}
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
Coverage ? 97.53%
=========================================
Files ? 6
Lines ? 284
Branches ? 41
=========================================
Hits ? 277
Misses ? 7
Partials ? 0
Continue to review full report at Codecov.
|
Member
|
OR 的功能估计也需要考虑一下 eggjs/egg#1035 |
|
几个月过去了，这个 PR 还有下文吗 |
|
这个PR还有下文吗？ |
|
还有LIKE的场景，能不能支持~ @fengmk2 |
|
Any updates? |
|
哟，or会有吗？需要的老哥们，咱们组队贡献代码吧！？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
定制 where 查询条件时，研究了下源代码，发现仅支持
=和IN操作，本人项目开发到一半，发现不能满足需求，故扩展了 where 对象的能力，更加灵活可控。