[codex] Remove deprecated use-http option#3189
Draft
hengyunabc wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated --use-http download option from Arthas entrypoints (arthas-boot and as.sh), simplifies the boot download flow to always use the HTTPS download endpoint, and updates user-facing documentation/man page examples accordingly.
Changes:
- Removed the
--use-httpCLI flag fromarthas-boot(Bootstrap) andas.sh, including usage/help text. - Simplified
DownloadUtils.downArthasPackaging(...)by removing the HTTP/HTTPS switching parameter and updating call sites/tests. - Updated Chinese docs and Debian man page to remove
--use-httpfrom examples and option listings.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| site/docs/doc/quick-start.md | Removes --use-http from quick-start mirror example. |
| site/docs/doc/install-detail.md | Removes --use-http from install instructions mirror example. |
| README_CN.md | Removes --use-http from the Chinese README mirror example. |
| packaging/src/deb/man1/arthas.1 | Removes --use-http from synopsis and options list. |
| boot/src/test/java/com/taobao/arthas/boot/DownloadUtilsTest.java | Updates tests for new downArthasPackaging signature. |
| boot/src/test/java/com/taobao/arthas/boot/BootstrapTest.java | Adds regression test ensuring use-http is absent from generated usage text. |
| boot/src/main/java/com/taobao/arthas/boot/DownloadUtils.java | Removes HTTP fallback logic and updates TLS error message. |
| boot/src/main/java/com/taobao/arthas/boot/Bootstrap.java | Removes --use-http option wiring and updates download calls/usage examples. |
| bin/as.sh | Removes --use-http parsing and references from usage/examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| AnsiLog.error("TLS connect error, please try to add --use-http argument."); | ||
| AnsiLog.error("TLS connect error, please check local Java TLS configuration."); | ||
| AnsiLog.error("URL: " + urlString); | ||
| AnsiLog.error(e); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation