Skip to content

The operation to remove the 'Container' object is placed when 'deallo… #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lovelymuz wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −4
Open

The operation to remove the 'Container' object is placed when 'deallo… #2237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ios/Classes/FlutterBoostPlugin.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ typedef void (^FBVoidCallback)(void);
- (void)containerDisappeared:(id<FBFlutterContainer>)container;
- (void)containerDestroyed:(id<FBFlutterContainer>)container;
- (void)onBackSwipe;
- (void)removeContainerWhenDealloc:(id<FBFlutterContainer>)container;

- (FBVoidCallback)addEventListener:(FBEventListener)listener forName:(NSString *)key;
+ (FlutterBoostPlugin* )getPlugin:(FlutterEngine*)engine ;
Expand Down
11 changes: 7 additions & 4 deletions ios/Classes/FlutterBoostPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,13 @@ - (void)containerDestroyed:(id<FBFlutterContainer>)vc {
[self.flutterApi removeRouteParam:params
completion:^(NSError * e) {
}];
[self.containerManager removeContainerByUniqueId:vc.uniqueIDString];
if (self.containerManager.containerSize == 0) {
[FBLifecycle pause];
}
}

- (void)removeContainerWhenDealloc:(id<FBFlutterContainer>)container {
[self.containerManager removeContainerByUniqueId:container.uniqueIDString];
if (self.containerManager.containerSize == 0) {
[FBLifecycle pause];
}
}

+ (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar> *)registrar {
Expand Down
1 change: 1 addition & 0 deletions ios/Classes/container/FBFlutterViewContainer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ - (void)dealloc {
if (self.removeEventCallback != nil) {
self.removeEventCallback();
}
[FB_PLUGIN removeContainerWhenDealloc:self];
[NSNotificationCenter.defaultCenter removeObserver:self];
_leftEdgeGesture.delegate = nil;
}
Expand Down