-
Notifications
You must be signed in to change notification settings - Fork 875
fix(helm,podmonitor): add podMonitorSelector for gateway metrics configuration #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
修复 PodMonitor 标签选择器配置以支持网关指标变更概述
变更文件
💡 小贴士与 lingma-agents 交流的方式📜 直接回复评论
📜 在代码行处标记
📜 在讨论中提问
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
==========================================
+ Coverage 35.91% 45.07% +9.16%
==========================================
Files 69 82 +13
Lines 11576 10898 -678
==========================================
+ Hits 4157 4912 +755
+ Misses 7104 5639 -1465
- Partials 315 347 +32 🚀 New features to boost your workflow:
|
|
@lwpk110 Please also update the README for helm: |
8cf8302 to
b250803
Compare
|
@johnlanni Have done |
2256ab4 to
5350a0e
Compare
5350a0e to
a74cd7f
Compare

Ⅰ. Describe what this PR did
gateway.metrics.labelsin the PodMonitor templateⅡ. Does this pull request fix one issue?
fixes #3021
Ⅲ. Why don't you add test cases (unit test/integration test)?
no need
Ⅳ. Describe how to verify it
helm template higress-core . --set gateway.metrics.enabled=true > foo.yaml
Ⅴ. Special notes for reviews
no