Cleanup mesh usage for sfm #2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servantftransperfect
force-pushed
the
dev/meshSfm
branch
2 times, most recently
from
8fbcd1e to
bb511e8
Compare
servantftransperfect
requested review from
Copilot
and removed request for
CedricThebault
Copilot finished reviewing on behalf of
servantftransperfect
November 19, 2025 10:27
servantftransperfect
force-pushed
the
dev/meshSfm
branch
from
bb511e8 to
da5a3c0
Compare
Copilot finished reviewing on behalf of
servantftransperfect
November 19, 2025 11:08
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| value="", | ||
| desc.FloatParam( | ||
| name="framerate", | ||
| label="Framerate", |
Member
There was a problem hiding this comment.
Suggested change
| label="Framerate", | |
| label="Frame Rate", |
Comment on lines
32
to
33
| description="Alembic doesn't export the camera resolutions. \n" | ||
| "Setup the images width for all images, the height will depends on the sensor size ratio.", |
Member
There was a problem hiding this comment.
Suggested change
| description="Alembic doesn't export the camera resolutions. \n" | |
| "Setup the images width for all images, the height will depends on the sensor size ratio.", | |
| description="Alembic does not export camera resolutions. \n" | |
| "Setup the image width for all images, the height will depend on the sensor size ratio.", |
| ), | ||
| desc.FloatParam( | ||
| name="framerate", | ||
| label="Framerate", |
Member
There was a problem hiding this comment.
Suggested change
| label="Framerate", | |
| label="Frame Rate", |
| description="Alembic frame rate to compute frame id from time", | ||
| value=24.0, | ||
| range=(10.0, 50.0, 1.0), | ||
| enabled=lambda node: pathlib.Path(node.posesFilename.value).suffix == ".abc" |
Member
There was a problem hiding this comment.
Suggested change
| enabled=lambda node: pathlib.Path(node.posesFilename.value).suffix == ".abc" | |
| enabled=lambda node: pathlib.Path(node.posesFilename.value).suffix.lower() == ".abc" |
| " - EulerZXY: Euler rotation in degrees (Y*X*Z)", | ||
| values=["EulerZXY"], | ||
| value="EulerZXY", | ||
| enabled=lambda node: pathlib.Path(node.posesFilename.value).suffix == ".json" |
Member
There was a problem hiding this comment.
Suggested change
| enabled=lambda node: pathlib.Path(node.posesFilename.value).suffix == ".json" | |
| enabled=lambda node: pathlib.Path(node.posesFilename.value).suffix.lower() == ".json" |
| for (int idRef = 0; idRef < possibleParameters.size(); idRef++) | ||
| { | ||
| const Vec3 & refpt = possibleParameters[idRef].first; | ||
| const Vec3 & refnormal = possibleParameters[idRef].second; |
Member
There was a problem hiding this comment.
this normal is not used ?
Comment on lines
+384
to
+387
| if (count > bestInliersCount) | ||
| { | ||
| bestInliersCount = count; | ||
| result = landmark; | ||
| } |
Member
There was a problem hiding this comment.
The score is just the number of times the landmark would be seen as inlier.
In some cases, this score could be the same for different landmark candidates.
For the score, we could sum up the reprojections error (and potentially add an extra value (e.g. _maxError) in case the reprojection error is bigger than the inlier threshold)
|
|
||
|
|
||
| cam->setSensorWidth(happ / (dw / sensorWidthPix)); | ||
| cam->setSensorHeight(vapp / (dh / sensorWidthPix)); |
Member
There was a problem hiding this comment.
since dh = dw * vapp / happ
SensorHeight = vapp / (dh / sensorWidthPix)
SensorHeight = vapp / ( (dw * vapp / happ) / sensorWidthPix)
SensorHeight = happ / (dw / sensorWidthPix)
SensorHeight = SensorWidth
| po::options_description optionalParams("Optional parameters"); | ||
| optionalParams.add_options() | ||
| ("imageWidth", po::value<int>(&imageWidth)->default_value(imageWidth), | ||
| "Alembic doesn't export the camera resolutions. Setup the images width for all images, the height will depends on the sensor size ratio.") |
Member
There was a problem hiding this comment.
Suggested change
| "Alembic doesn't export the camera resolutions. Setup the images width for all images, the height will depends on the sensor size ratio.") | |
| "Alembic does not export camera resolutions. Setup the image width for all images, the height will depend on the sensor size ratio.") |
| } | ||
|
|
||
| /** | ||
| * @brief Get a set of poses from a alembic file (assumes the file format is ok). |
Member
There was a problem hiding this comment.
Suggested change
| * @brief Get a set of poses from a alembic file (assumes the file format is ok). | |
| * @brief Get a set of poses from an alembic file (assumes the file format is ok). |
servantftransperfect
force-pushed
the
dev/meshSfm
branch
2 times, most recently
from
eccce63 to
71ccf03
Compare
added 2 commits
November 27, 2025 08:47
servantftransperfect
force-pushed
the
dev/meshSfm
branch
from
71ccf03 to
1ffa948
Compare
CedricThebault
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.