Skip to content

Conversation

@jackmacaa
Copy link
Contributor

Update to readMe is root of repo

@jackmacaa jackmacaa requested a review from a team as a code owner February 5, 2025 04:46
@jackmacaa
Copy link
Contributor Author

@TheOrangePuff @tvhees Can you guys approve please?

Copy link
Contributor

@tvhees tvhees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Jack

@tvhees
Copy link
Contributor

tvhees commented Feb 10, 2025

@TheOrangePuff the code quality step is failing despite there being no change that should impact it here. That's concerning.

@jackmacaa
Copy link
Contributor Author

@TheOrangePuff the code quality step is failing despite there being no change that should impact it here. That's concerning.

Taking a look now.

@jackmacaa
Copy link
Contributor Author

@tvhees I cant replicate this issue from my local. i have tried running the same step that is failing: nx run bigcommerce-operations:codegen, its running it from the cache though. So i also tried running nx run bigcommerce-operations:codegen --clear-nx-cache, with not luck to replicate either.

I have noticed a difference though, when i run the above commands my root package.json gets " "packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04da" line added to it, which the origin repo does not contain.

The message in the terminal are:
! The local project doesn't define a 'packageManager' field. Corepack will now add one referencing [email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e. ! For more details about this field, consult the documentation at https://nodejs.org/api/packages.html#packagemanager
So im guessing this line is just for local dev and should no be commited.

It does seem like the --clear-nx-cache isnt working correctly in my local based on the terminal output.

@jackmacaa jackmacaa changed the title MI-170 swapped over aligent meshn repo link to github MI-170 swapped over aligent mesh repo link to github link Feb 10, 2025
@tvhees tvhees merged commit d85df57 into main Feb 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants