Fix green-20220302 import without websocket helpers#44
Open
AndersonBY wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
With alibabacloud-green20220302 3.4.0 and alibabacloud-tea-openapi 0.4.4, this currently fails during import:
The failure is caused by generated MultiModalGuardWs code importing
alibabacloud_tea_openapi.websocketUtils_modelsandalibabacloud_tea_openapi.websocketUtilsat module import time. Those modules are not present in the currently released alibabacloud-tea-openapi 0.4.4 package.This PR does not claim MultiModalGuardWs works without the websocket helper support. It only avoids breaking unrelated APIs such as TextModeration at import time.
Test
cd green-20220302 && /tmp/green-20220302-pr-venv/bin/python -m pytest tests/test_import.py -qcd green-20220302 && /tmp/green-20220302-pr-venv/bin/python -m compileall -q alibabacloud_green20220302git diff --check