mapchooser: Set minimum number maps to include in vote #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows the user to have a consistent number minimum number of maps in the vote, regardless how many previous maps are excluded. It also improves the handling of the situation, when the number is previous maps to exclude is set higher than the number of available maps. Instead of excluding no previous maps, it will exclude until there's a configurable number of minimum options left.
Contributor
Author
|
Tested and ready to be merged. The only bug I came across was a separate issue related to PR #1197. |
Member
|
@stickz can you rebase? |
Contributor
Author
|
@KyleSanderson re-based in pull request #1333. |
Member
|
You don't need to open a new pull request for a rebase. You can rebase your branch onto master and force-push to update this PR. |
Member
|
indeed, thanks @peace-maker for calling that out. @stickz why does this keep happening? |
Contributor
Author
|
Sorry, not very experienced with GitHub. The last time I tried to resolve a file conflict it merged 200 files into my pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the user to have a consistent minimum number of maps in the vote, regardless how many previous maps are excluded. It also improves the handling of the situation, when the number of previous maps to exclude is set higher than the number of available maps. Instead of excluding no previous maps, it will exclude until the minimum include count is reached.