Use %zu printf format for type size_t - #2976
Merged
Merged
Conversation
On 32-bit environments, ‘size_t’ is a 32-bit type, whereas ‘unsigned
long’ is 64 bits long. As the %lu printf format expects an unsigned long
argument, it cannot be used portably with a size_t argument. Use the
proper %zu instead.
Fixes:
* src/bin2c.c:119:39: warning: format ‘%lu’ expects argument of type
‘long unsigned int’, but argument 4 has type ‘size_t’ {aka ‘unsigned
int’} [-Wformat=]
* the same warning on line 137
Owner
|
Awesome. Merged. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am still using a 32-bit netbook, and even compiling stuff on it. Yes, I know it's outdated. While building goaccess, I got this GCC warning:
and the same warning on line 137.
This pull request fixes the printf format, which should be
%zu.