add conditional compilation for Windows-specific test imports #3218
+13
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xLogicalx
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
onbjerg
requested changes
Nov 20, 2025
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| #[cfg(not(windows))] |
Contributor
There was a problem hiding this comment.
just hoist this to the module level since there are no windows tests in here
Contributor
Author
There was a problem hiding this comment.
Hoisted the #[cfg(not(windows))] to the module level so the whole tests module is skipped on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix clippy unused import warnings by adding conditional compilation attributesto platform-specific test imports.