fixes an issue where the git clone exec resource was being called everytime - #72
Open
logicminds wants to merge 1 commit into
Open
fixes an issue where the git clone exec resource was being called everytime#72logicminds wants to merge 1 commit into
logicminds wants to merge 1 commit into
Conversation
Contributor
|
I don't see why this would produce any different behavior as any other exec with that contain an creates parameter, how do you reproduce this? I used puppet 3.1.1 on ubuntu 12.04 lts with no issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason when I used the rbenv::plugin, the creates parameter in this resource was not behaving correctly which caused errors when git clone is run. Essentially, git refuses to clone the repo when the destination already exists.
The fix in the pull request essentially does the same thing as creates but actually works.
Error: git clone git://github.com/jamis/rbenv-gemset.git /var/www/.rbenv/plugins/rbenv-gemset returned 128 instead of one of [0]
exec { "rbenv::plugin::checkout ${user} ${plugin_name}":
command => "git clone ${source} ${destination}",
user => $user,
group => $group,
creates => "$destination",
path => ['/usr/bin', '/usr/sbin'],
timeout => $timeout,
cwd => $home_path,
require => File["rbenv::plugins ${user}"],
}