Skip to content

update translations#387

Closed
barredterra wants to merge 2 commits into
version-16-hotfixfrom
update-translations
Closed

update translations#387
barredterra wants to merge 2 commits into
version-16-hotfixfrom
update-translations

Conversation

@barredterra

Copy link
Copy Markdown
Member
  • ci: add PO review workflow
  • chore: update translations

@greptile-apps

greptile-apps Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

The translation file changes are mechanical and safe. The new workflow file is functional but relies on a mutable action tag.

All locale and POT changes are straightforward string additions and line-reference updates with no missing translations. The only notable point is the alyf-de/po-review-action@v1 reference in the new workflow, which uses a mutable tag; pinning to a commit SHA would be more resilient to tag mutation.

.github/workflows/translation-review.yaml — the action reference should be pinned to a commit SHA before this workflow is depended upon in production.

Sequence Diagram

sequenceDiagram
    participant Fork as Fork / PR Author
    participant GH as GitHub Actions (pull_request_target)
    participant Action as alyf-de/po-review-action@v1
    participant Repo as Base Repository (alyf-de/banking)

    Fork->>GH: "Opens / updates PR with *.po or *.pot changes"
    GH->>GH: Trigger: pull_request_target (base repo context)
    GH->>Action: Run action (contents:read, issues:write, pull-requests:write)
    Action->>Repo: Read .po / .pot files from PR
    Action->>Repo: Post review comments on PR (write token)
Loading

Fix All in Cursor

Reviews (1): Last reviewed commit: "chore: update translations" | Re-trigger Greptile

Comment thread .github/workflows/translation-review.yaml Outdated
@barredterra barredterra force-pushed the update-translations branch from 99e9438 to 7ea6ee4 Compare June 7, 2026 21:30
@barredterra barredterra force-pushed the update-translations branch from 7ea6ee4 to 014cbfd Compare June 7, 2026 21:32
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

Here is a summary of the .po file changes:

  • Changed files: 5
  • Added files: 0
  • Removed files: 0
  • Files in similar change-size groups within 2% tolerance: 5
  • Added or changed translations detected: 16 across 1 file(s)

Similar Change-Size Groups

  • Around +188 / -124 lines: 5 files (de.po, es.po, fr.po, it.po, nl.po)
Added or changed translations by language (16 entries across 1 file(s))

de (banking/locale/de.po)

Status Msgid Previous Current
added A <b>Journal Entry</b> is created automatically, when a submitted <b>Bank Transaction</b> matches these filters.<br>Please define these filters as strictly as possible to avoid accounting errors.<br><br> empty Ein <b>Buchungssatz</b> wird automatisch erstellt, wenn eine gebuchte <b>Banktransaktion</b> diesen Filtern entspricht.<br>Bitte definieren Sie diese Filter so streng wie möglich, um Buchungsfehler zu vermeiden.<br><br>
added A SEPA Payment Order already exists for Expense Claim {0}. empty Eine SEPA-Überweisung existiert bereits für die Auslagenabrechnung {0}.
added Account Settings empty Kontoeinstellungen
added Auto-created from Bank Transaction {0} empty Automatisch erstellt aus Banktransaktion {0}
added Auto-created from Bank Transaction {0} by Bank Reconciliation Rule {1} empty Automatisch erstellt aus Banktransaktion {0} durch Bankabgleichsregel {1}
added Bank Account and Target Account need to be in the same currency! empty Bankkonto und Zielkonto müssen in der gleichen Währung sein!
added Bank Reconciliation Rule empty Bankabgleichsregel
changed Failed to re-import EBICS transactions. Fehler beim erneuten Importieren von EBICS-Transaktionen. empty
added If multiple rules match a <b>Bank Transaction</b>, only the one with the highest priority is executed. empty Wenn mehrere Regeln auf eine <b>Banktransaktion</b> zutreffen, wird nur die mit der höchsten Priorität ausgeführt.
added In {0} {1} the field {2} is not set. empty Im {0} {1} ist das Feld {2} nicht gesetzt.
added No IBAN found for Employee {0}. empty Keine IBAN für Mitarbeiter {0} gefunden.
added Only submitted, approved and unpaid Expense Claims without an existing SEPA Payment Order can be used. Rejected, paid or already linked claims were ignored. empty Nur eingereichte, genehmigte und unbezahlte Auslagenabrechnungen ohne vorhandene SEPA-Überweisung können verwendet werden. Abgelehnte, bezahlte oder bereits verlinkte Ansprüche wurden ignoriert.
added Please define at least one filter! empty Bitte definieren Sie mindestens einen Filter!
added Target Account empty Zielkonto
added The field {0} is negative. Please verify the input data. empty Das Feld {0} ist negativ. Bitte überprüfen Sie die Eingabedaten.
added The field {0} is required. Please verify the input data. empty Das Feld {0} ist erforderlich. Bitte überprüfen Sie die Eingabedaten.

Metadata-Only File Changes

  • es (banking/locale/es.po)
  • fr (banking/locale/fr.po)
  • it (banking/locale/it.po)
  • nl (banking/locale/nl.po)

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Template string changes (16 added, 5 removed across 1 file(s))

banking/locale/main.pot

Added:

  • A <b>Journal Entry</b> is created automatically, when a submitted <b>Bank Transaction</b> matches these filters.<br>Please define these filters as strictly as possible to avoid accounting errors.<br><br>
  • A SEPA Payment Order already exists for Expense Claim {0}.
  • Account Settings
  • Auto-created from Bank Transaction {0}
  • Auto-created from Bank Transaction {0} by Bank Reconciliation Rule {1}
  • Bank Account and Target Account need to be in the same currency!
  • Bank Reconciliation Rule
  • If multiple rules match a <b>Bank Transaction</b>, only the one with the highest priority is executed.
  • In {0} {1} the field {2} is not set.
  • Invalid sort order.
  • No IBAN found for Employee {0}.
  • Only submitted, approved and unpaid Expense Claims without an existing SEPA Payment Order can be used. Rejected, paid or already linked claims were ignored.
  • Please define at least one filter!
  • Target Account
  • The field {0} is negative. Please verify the input data.
  • The field {0} is required. Please verify the input data.

Removed:

  • <span class="h4">Banking</span>
  • Bank Reconciliation
  • EBICS Users
  • SEPA Payment Orders
  • {} Unreconciled

@barredterra barredterra closed this Jun 7, 2026
@barredterra barredterra deleted the update-translations branch June 7, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant