Normalize missing DNS server ports to 53 - #124
Open
yankewei wants to merge 1 commit into
Open
Conversation
yankewei
force-pushed
the
codex/fix-nameserver-port-validation
branch
from
July 29, 2026 14:58
47fd387 to
542ad65
Compare
yankewei
marked this pull request as ready for review
July 29, 2026 15:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DnsConfig::getNameservers()Root cause
DnsConfigused port 53 while validating a nameserver without a port, but discarded that local default and stored the original address. The resolver later passed an incomplete endpoint such asudp://1.1.1.1tostream_socket_client(), which requires a port.This change writes the validated, normalized endpoint back into the configuration, so callers can continue omitting the standard DNS port while the socket layer always receives a complete address.
Fixes #123.
Validation
vendor/bin/phpunit test/DnsConfigTest.php test/Rfc1035StubResolverTest.php(29 tests, 29 assertions)composer csvendor/bin/psalm.phar --no-cacheThe complete test suite was also run locally. Three tests that depend on the local proxy DNS and timeout behavior still fail in this environment, as they did before this revision; the GitHub Actions matrix passes on all seven PHP and OS jobs.