This repository was archived by the owner on Jan 20, 2025. It is now read-only.
bugfix(derive) implicit discriminants were wrongly calculated - #11
Open
nduchaux wants to merge 2 commits into
Open
bugfix(derive) implicit discriminants were wrongly calculated#11nduchaux wants to merge 2 commits into
nduchaux wants to merge 2 commits into
Conversation
Author
|
The second commit permits to "parse" any numeric literals (e.g. 0x1234). This was not the case for the first one (or even before that). |
added 2 commits
December 17, 2023 09:19
…D0123 or any literal not parsable by u32::from_str )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a enum variant had no explicit discriminant, there was a try to calculate it by looking at the previous one.
This was not working at all:
This commit corrects the logic to make it work.