Skip to content

Conversation

@NicuS03
Copy link

@NicuS03 NicuS03 commented Sep 22, 2025

With this patch the U-Boot file is automatically downloaded from SwDownload based on a property called "PATH_TO_FILE" that is provided inside the xsa file.

Signed-off-by: Nicu Siderias <[email protected]>
@NicuS03 NicuS03 marked this pull request as ready for review September 22, 2025 06:58
Signed-off-by: Nicu Siderias <[email protected]>
@NicuS03 NicuS03 marked this pull request as draft November 10, 2025 11:15
@NicuS03 NicuS03 force-pushed the feature/download_uboot branch 5 times, most recently from 6613770 to b5a187b Compare November 10, 2025 11:21
@NicuS03 NicuS03 marked this pull request as ready for review November 10, 2025 11:41
@NicuS03 NicuS03 requested a review from SRaus November 10, 2025 11:41
Add posibility to either download the u-boot or use the desire .elf

Signed-off-by: Nicu Siderias <[email protected]>
@NicuS03 NicuS03 force-pushed the feature/download_uboot branch from b5a187b to 5e91af3 Compare November 13, 2025 07:23
set -ex

XSA_FILE=$1
UBOOT_FILE=$2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to let u-boot file argument as optional - users come many times with their own u-boot.

$OUTPUT_DIR='output_boot_bin'

function usage () {
echo "usage:powershell.exe .\build_boot_bin.ps1 system_top.xsa u-boot.elf [output-archive]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let the possibility to come with own u-boot (optional parameter).

Select-Object -First 1 -ExpandProperty Line
$carrier = [regex]::Match($line, $regex).Value

switch -Wildcard ($carrier) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment there that we offer prebuilt u-boot... but they come also with the own one.

Comment on lines 49 to 50
"ccfmc_*" { $UBOOT_FILE = "u-boot_zynq_adrv9361.elf" }
"ccbob_*" { $UBOOT_FILE = "u-boot_zynq_adrv9361.elf" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge this in a single case

"zc706" { $UBOOT_FILE = "u-boot_zynq_zc706.elf" }
"coraz7s" { $UBOOT_FILE = "u-boot_zynq_coraz7.elf" }
Default {
Write-Host "`n`n!!!!! Undefined carrier name for uboot selection !!!!!`n`n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be "undefined carrier" just because we do not provide a prebuilt u-boot for specific carrier,

jupiter_sdr) UBOOT_FILE="u-boot_zynqmp-jupiter-sdr.elf" ;;
k26) UBOOT_FILE="u-boot_zynqmp-smk-k26-revA-wrapper.elf" ;;
*)
echo "\n\n!!!!! Undefined carrier name for uboot selection !!!!!\n\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as for 32 bits configs

@NicuS03
Copy link
Author

NicuS03 commented Nov 14, 2025

@SRaus I think you look at the first commit. I update the implementation this week to let them provide an elf or download the elf.
About the last 2 comments, what exactly should I do if they want to use the download functionality and come with a xsa that have an carrier that we don't support ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants