-
Notifications
You must be signed in to change notification settings - Fork 5
Download u-boot from SwDownload #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nicu Siderias <[email protected]>
Signed-off-by: Nicu Siderias <[email protected]>
6613770 to
b5a187b
Compare
Add posibility to either download the u-boot or use the desire .elf Signed-off-by: Nicu Siderias <[email protected]>
b5a187b to
5e91af3
Compare
| set -ex | ||
|
|
||
| XSA_FILE=$1 | ||
| UBOOT_FILE=$2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to let u-boot file argument as optional - users come many times with their own u-boot.
| $OUTPUT_DIR='output_boot_bin' | ||
|
|
||
| function usage () { | ||
| echo "usage:powershell.exe .\build_boot_bin.ps1 system_top.xsa u-boot.elf [output-archive]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let the possibility to come with own u-boot (optional parameter).
zynq_boot_bin/build_boot_bin.ps1
Outdated
| Select-Object -First 1 -ExpandProperty Line | ||
| $carrier = [regex]::Match($line, $regex).Value | ||
|
|
||
| switch -Wildcard ($carrier) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment there that we offer prebuilt u-boot... but they come also with the own one.
zynq_boot_bin/build_boot_bin.ps1
Outdated
| "ccfmc_*" { $UBOOT_FILE = "u-boot_zynq_adrv9361.elf" } | ||
| "ccbob_*" { $UBOOT_FILE = "u-boot_zynq_adrv9361.elf" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge this in a single case
zynq_boot_bin/build_boot_bin.ps1
Outdated
| "zc706" { $UBOOT_FILE = "u-boot_zynq_zc706.elf" } | ||
| "coraz7s" { $UBOOT_FILE = "u-boot_zynq_coraz7.elf" } | ||
| Default { | ||
| Write-Host "`n`n!!!!! Undefined carrier name for uboot selection !!!!!`n`n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be "undefined carrier" just because we do not provide a prebuilt u-boot for specific carrier,
| jupiter_sdr) UBOOT_FILE="u-boot_zynqmp-jupiter-sdr.elf" ;; | ||
| k26) UBOOT_FILE="u-boot_zynqmp-smk-k26-revA-wrapper.elf" ;; | ||
| *) | ||
| echo "\n\n!!!!! Undefined carrier name for uboot selection !!!!!\n\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as for 32 bits configs
|
@SRaus I think you look at the first commit. I update the implementation this week to let them provide an elf or download the elf. |
With this patch the U-Boot file is automatically downloaded from SwDownload based on a property called "PATH_TO_FILE" that is provided inside the xsa file.