Update window manager version to 1.5.1 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekbatra-g
force-pushed
the
prateek/update_windowmanager_version_1.5.1
branch
from
a3d63cd to
a9dc992
Compare
romanofranz
requested changes
Nov 28, 2025
Contributor
romanofranz
left a comment
romanofranz
left a comment
There was a problem hiding this comment.
Hey Prateek, please update targetSdk and compileSdk to 36
WindowManager/app/build.gradle
Outdated
| android { | ||
| namespace "com.example.codelab.windowmanager" | ||
| compileSdk 33 | ||
| compileSdk 34 |
WindowManager/app/build.gradle
Outdated
| applicationId "com.example.codelab.windowmanager" | ||
| minSdk 21 | ||
| minSdk 23 | ||
| targetSdk 33 |
Contributor
There was a problem hiding this comment.
targetSdk should be 36 too
prateekbatra-g
force-pushed
the
prateek/update_windowmanager_version_1.5.1
branch
from
a9dc992 to
ceeb65c
Compare
chikoski
reviewed
Dec 1, 2025
| } | ||
|
|
||
| dependencies { | ||
| ext.windowmanager_version = "1.1.0" |
Contributor
There was a problem hiding this comment.
Would you introduce libs.version.toml, instead of describing the version number here?
Author
There was a problem hiding this comment.
We are utilizing this as part of codelab, so this might be needed to show which explicit version pick
@romanofranz cmiiw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.