Changes to make it work on current node.js version#1
Open
pushpalakalyan wants to merge 1 commit intoandykent:masterfrom
Open
Changes to make it work on current node.js version#1pushpalakalyan wants to merge 1 commit intoandykent:masterfrom
pushpalakalyan wants to merge 1 commit intoandykent:masterfrom
Conversation
- Updated the depreciated http.createClient to http.Request as existing code doesnt work out of the box on new node.js version - also the current version throws exception at request.close() API. Changed it to request.end() works now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Andykent,
I was looking for a webhook delivery platform and found yours. its a good one but did not work for me at first as no deliveries made to the test server:request.in. Fixed below issues and now it works great. I do not know JS but googled around to make it work so review and accept.
Any plans on providing reliability with a queuing backend?
code doesnt work out of the box on new node.js version
Changed it to request.end() works now.