Skip to content

build: switch codeql trigger to pull_request and harden actions/checkout - #4065

Merged
alan-agius4 merged 1 commit into
angular:mainfrom
josephperrott:fix/codeql-pull-request-trigger
Oct 24, 2026
Merged

alan-agius4 merged 1 commit into
angular:mainfrom
josephperrott:fix/codeql-pull-request-trigger

Conversation

@josephperrott

Copy link
Copy Markdown
Member

This change switches .github/workflows/codeql.yml from pull_request_target to pull_request per GHSS pull_request_target policy remediation (b/577107346). Because CodeQL analysis requires no secrets or write permissions, running on pull_request ensures untrusted fork code cannot execute with elevated privileges and fixes CodeQL analysis on PRs.

Additionally, this change removes the obsolete zizmor ignore comment and adds persist-credentials: false to actions/checkout steps in codeql.yml and dev-infra.yml for defense-in-depth.

Switches .github/workflows/codeql.yml from pull_request_target to pull_request, removes the obsolete zizmor ignore comment, and adds persist-credentials: false to actions/checkout steps in codeql.yml and dev-infra.yml for defense-in-depth.
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 23, 2026
@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Oct 23, 2026
@alan-agius4
alan-agius4 merged commit 1183a2e into angular:main Oct 24, 2026
19 checks passed
@alan-agius4

Copy link
Copy Markdown
Contributor

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants