Merge defaults across successive tasks - #399
Open
johnlettman wants to merge 1 commit into
Open
Conversation
Recursively merge Dotbot defaults instead of replacing the existing mapping, preserving unrelated plugin settings while allowing later values to override specific nested options. Add regression tests covering nested merges, overrides, and input isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recursively merge Dotbot defaults instead of replacing the existing mapping, preserving unrelated plugin settings while allowing later values to override specific nested options.
The change makes successive
defaultsdirectives merge recursively instead of replacing the entire defaults mapping.Example
Starting from the following example:
When the
metbranch runs, Dotbot now produces defaults equivalent to:Previously, adding the
parudefaults replaced the entire mapping, silently discarding the existingshell,link, andsyncsettings. Recursive merging preserves those settings while allowing the conditional branch to add or override onlyparu.interactive.