Skip to content

Fix for missing return statements - #8

Open
mirjalal wants to merge 1 commit into
anitaa1990:masterfrom
mirjalal:master
Open

mirjalal wants to merge 1 commit into
anitaa1990:masterfrom
mirjalal:master

Conversation

@mirjalal

Copy link
Copy Markdown
Contributor

return statements added to fire callback(s) on time.

I tested on my device (LG G4 running w/ Android 6.0 has no any biometric auth related software & hardware component) & as a result without the return statements exception thrown.

`return` statements added to fire callback(s) on time. 

I tested on my device (LG G4 running w/ Android 6.0 has no any biometric auth related software & hardware component) & as a result without the `return` statements exception thrown.
@Sammekl

Sammekl commented Apr 29, 2019

Copy link
Copy Markdown

This PR is not necessary when #9 gets merged, which I prefer due to additional functionality

@mirjalal

mirjalal commented Apr 30, 2019

Copy link
Copy Markdown
Contributor Author

@Sammekl PR #9 was opened after this PR (#8) created. Also, PR #9 is based on this comment which I made it before #9 was opened. Thus, there is a small conflict and similarity between #8 and #9. Of course, it is all up to you ;)

Cheers!

@Sammekl Sammekl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As #9 has been successfully merged, this is no longer necessary. Thanks for the PR though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants