Changes download to not write file before sending response#474
Open
ronualdo wants to merge 1 commit intoankane:masterfrom
Open
Changes download to not write file before sending response#474ronualdo wants to merge 1 commit intoankane:masterfrom
ronualdo wants to merge 1 commit intoankane:masterfrom
Conversation
Changes action to avoid writing the whole file to the disk before sending the response and potentially triggering response timeouts.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a few cases where the download action is triggering server timeouts because it seems that Blazer is writing the whole CSV to the disk before sending the response. I was wondering if we could use
response.streaminstead to avoid this type of scenario.I've opened this PR with an initial implementation. Would love to hear any thoughts on this.