Skip to content

Backend updates for Execution Environment Experience #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Backend updates for Execution Environment Experience #10

wants to merge 33 commits into from

Conversation

@NilashishC
Copy link
Collaborator

@NilashishC NilashishC commented Nov 12, 2025 •
edited
Loading

Moved from #3

  • Adds backend scaffolder actions for EE definition file creation, EE template creation, catalog descriptor creation and dynamic registration, SCM publishing pre-checks.
  • Adds a new EntityProvider for registering EE entities on the fly.
  • Adds a new route to rhaap catalog plugin router for registering EE via the AAPEntityProvider.

@NilashishC NilashishC changed the title Backend updates for Execution Environment Experienc Backend updates for Execution Environment Experience Nov 12, 2025
@NilashishC NilashishC requested review from Pavanjangle and audgirka and removed request for audgirka November 12, 2025 06:01
@NilashishC NilashishC requested review from Pavanjangle, abhikdps, audgirka and ganeshrn and removed request for Pavanjangle November 12, 2025 06:01
audgirka
audgirka requested changes Nov 13, 2025
View reviewed changes
@codecov-commenter

This comment was marked as outdated.

Sign in to view
@NilashishC NilashishC requested a review from audgirka November 14, 2025 05:42
abhikdps
abhikdps reviewed Nov 14, 2025
View reviewed changes
@NilashishC NilashishC requested a review from abhikdps November 14, 2025 07:35
@NilashishC
backend updates for EE definition generation
9291dc1 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
fix CI
a8e2339 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
fix tests
6fb928a 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
fix README typo
ce7dfc5 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
add back tsconfig.json
01987ae 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
drop fs-extra as dep
11a61b5 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
Add EE definition schema validation
7b1bac2 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
additional entries in collection schema
a35fbca 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
add unit tests for createEEDefinitionAction
c1de0ae 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
Add unit tests for createEETemplateAction
ba1d724 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
Add tests for createEECatalogInfoAction
67eef4b 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
Add unit tests for prepareForPublishAction
9eaf830 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
Add support view details in catalog link
f28f7e8 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
updates
836c54d 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
address review comments
e7bd8b4 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
refactor actions and related tests
0b909f8 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
fix generated template
f952837 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
Add tests for new methods in UseCaseMaker
e228ce0 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
Add new entity provider tests
2cf364b 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
remove stray file
363bf54 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
add tests for the new API endpoint in router.ts
b4d3b66 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
update README
617f27e 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
remove unused import
23a2a88 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
fix CI
b9a8349 
Signed-off-by: NilashishC <[email protected]>
@NilashishC
fix README generation
4c115dc 
Signed-off-by: NilashishC <[email protected]>
abhikdps
abhikdps reviewed Nov 17, 2025
View reviewed changes
plugins/scaffolder-backend-module-backstage-rhaap/src/actions/createEEDefinition.ts
// generate catalog descriptor file path for the Execution Environment
// this is only needed if the user has chosen to publish to a SCM repository
// and we are creating a catalog-info.yaml file using the built-in `catalog:write` action
const catalogInfoPath = path.join(eeDir, 'catalog-info.yaml');
Copy link
Contributor

@abhikdps abhikdps Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const catalogInfoPath = path.join(eeDir, 'catalog-info.yaml');
const catalogInfoPath = path.join(contextDirName, 'catalog-info.yaml');

The action catalog:write needs a relative path from the workspace root, whereas eeDir is an absolute path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhikdps abhikdps abhikdps left review comments

@ganeshrn ganeshrn Awaiting requested review from ganeshrn

@Pavanjangle Pavanjangle Awaiting requested review from Pavanjangle

@audgirka audgirka Awaiting requested review from audgirka

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NilashishC @codecov-commenter @audgirka @abhikdps