Skip to content

ci: expose OpenBLAS build failure logs - #2800

Merged
LHT129 merged 1 commit into
antgroup:mainfrom
jac0626:codex/openblas-failure-logs
Aug 31, 2026
Merged

LHT129 merged 1 commit into
antgroup:mainfrom
jac0626:codex/openblas-failure-logs

Conversation

@jac0626

@jac0626 jac0626 commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Change Type

  • Bug fix
  • New feature
  • Improvement/Refactor
  • Documentation
  • CI/Build/Infra

Linked Issue

What Changed

  • Merge stdout and stderr for logged OpenBLAS ExternalProject steps.
  • Replay the captured OpenBLAS build log when the ExternalProject step fails.

This keeps successful builds quiet while making intermittent bundled OpenBLAS failures visible in the job log, including failures inside temporary Python build containers.

Test Evidence

  • make fmt
  • make lint
  • make test
  • make cov, run tests, and collect coverage
  • Other (controlled ExternalProject failure A/B test and git diff --check)

Test details:

Used the repository openblas.cmake with the real OpenBLAS 0.3.24 archive and a controlled nested make command that writes distinct stdout/stderr sentinels, then exits 23.

Before:
  build status: failure
  stdout sentinel in console: 0
  stderr sentinel in console: 0
  sentinels retained in separate openblas-build-{out,err}.log files: yes

After:
  build status: failure
  stdout sentinel in console: 1
  stderr sentinel in console: 1
  both sentinels retained in openblas-build.log: yes
  CMake prints -- Log output is: before replaying the failure: yes

git diff --check: pass

Compatibility Impact

  • API/ABI compatibility: none
  • Behavior changes: failed logged ExternalProject steps now replay their captured output; successful builds are unchanged

Performance and Concurrency Impact

  • Performance impact: none expected
  • Concurrency/thread-safety impact: none

Documentation Impact

  • No docs update needed
  • Updated docs:
    • README.md
    • DEVELOPMENT.md
    • CONTRIBUTING.md
    • Other

Risk and Rollback

  • Risk level: low
  • Rollback plan: revert the commit to restore separate hidden stdout/stderr logs

Checklist

  • I have linked the relevant issues
  • No unit test is needed; the CMake behavior was verified with a controlled failure regression probe
  • I have considered API compatibility impact
  • No documentation update is required
  • My commit message follows project conventions

Signed-off-by: jc543239 <jc543239@antgroup.com>
Assisted-by: Codex:gpt-5
Copilot AI lite review requested due to automatic review settings August 28, 2026 08:31
@pull-request-size pull-request-size Bot added the size/XS 0-9 changed lines label Aug 28, 2026
@vsag-bot

vsag-bot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

/label status/waiting-for-review
/waiting-on reviewer
/request-review @jiaweizone
/request-review @wxyucs
/request-review @inabao

@jac0626 jac0626 added kind/improvement Optimizations, UX polish, or minor improvements 性能优化、体验打磨或细节改良 version/1.1 labels Aug 28, 2026
@mergify

mergify Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 2 merge protections satisfied — ready to merge.

Show 2 satisfied protections

🟢 Require kind label

  • label~=^kind/

🟢 Require version label

  • label~=^version/

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves CI diagnostics for the bundled OpenBLAS ExternalProject build by ensuring build logs are both captured in a single stream and automatically replayed into the job output when the ExternalProject step fails, while keeping successful builds quiet.

Changes:

  • Enable merged stdout/stderr logging for OpenBLAS ExternalProject steps.
  • Enable automatic log replay to the CMake/CI console on ExternalProject failure.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@LHT129 LHT129 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129
LHT129 merged commit d9af013 into antgroup:main Aug 31, 2026
20 of 23 checks passed
@wxyucs wxyucs added area/dependencies Vendored and external dependencies 内置及外部依赖 and removed module/thirdparty labels Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Vendored and external dependencies 内置及外部依赖 kind/improvement Optimizations, UX polish, or minor improvements 性能优化、体验打磨或细节改良 size/XS 0-9 changed lines version/1.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants