Skip to content

fix(examples/memory): properly add assistant_content to messages #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2025
Merged

fix(examples/memory): properly add assistant_content to messages #1049

merged 1 commit into from
Nov 18, 2025
+5 −5

Conversation

@HQidea
Copy link
Contributor

@HQidea HQidea commented Oct 22, 2025

This pr fixes:

  • Variable scope: The assistant_content variable was declared outside the message processing loop, causing content accumulation across multiple messages
  • Message ordering: Assistant messages were being stored after tool results, which violates the correct conversation flow where assistant messages should come before tool results

@HQidea HQidea requested a review from a team as a code owner October 22, 2025 08:12
@HQidea HQidea mentioned this pull request Oct 22, 2025
Open
@RobertCraigie RobertCraigie changed the base branch from main to next November 18, 2025 11:21
@RobertCraigie RobertCraigie changed the title fix: properly add assistant_content to messages fix(examples/memory): properly add assistant_content to messages Nov 18, 2025
@RobertCraigie RobertCraigie merged commit 7720d1d into anthropics:next Nov 18, 2025
4 checks passed
stainless-app bot pushed a commit that referenced this pull request Nov 18, 2025
@HQidea @stainless-app
fix(examples/memory): properly add assistant_content to messages (#1049)
9c7141b
@stainless-app stainless-app bot mentioned this pull request Nov 18, 2025
Merged
RobertCraigie pushed a commit that referenced this pull request Nov 18, 2025
@HQidea @RobertCraigie
fix(examples/memory): properly add assistant_content to messages (#1049)
ac3c167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@karpetrosyan karpetrosyan karpetrosyan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HQidea @karpetrosyan @RobertCraigie