PLEASE SEND PRS TO linenoise.cpp

[ericcurtin]

https://github.com/ericcurtin/linenoise.cpp

[andreca]

Hello @ericcurtin, are you the new maintainer?

[ericcurtin]

I wrote a new C++ version of it because I want to make it a little safer (and I also want to build it with C++ compilers, plan on using it for llama.cpp). I offer to maintain this fork, feel free to send any patches that you may have intended to send to the C version.

[ericcurtin]

@mzhang28 I'm surprised this got a thumbs down, nothing has been merged here in 11 months, it's essentially unmaintained, I'm offering to change that.

[yhirose]

@ericcurtin does your version have a UTF-8 string support which is lacking in the original linenoise? If so, I am interested in yours. :)

Here is my pull request to add UTF-8 support to the original linenoise. (Currently, it supports the latest Unicode 16.0.)
https://github.com/antirez/linenoise/pull/187/files
#25

[ericcurtin]

@yhirose if you open a PR for that in linenoise.cpp , write some unit tests, we can get it reviewed and merged.

[yhirose]

Great! I'll try to migrate my patch to linenoise.cpp and send the PR to your project. :)

[ngxson]

Hmm, I'm wondering we should offer @antirez some helps to maintain this project, rather than just take the code and move it somewhere else.

it's essentially unmaintained, I'm offering to change that.

There have been some works since, especially the CVE #240 that got merged to your downstream project.

So now I'm unsure if this PR actually caused harm to the original project or not.

[ericcurtin]

Hmm, I'm wondering we should offer @antirez some helps to maintain this project, rather than just take the code and move it somewhere else.

I agree, although the point of linenoise.cpp was to write a C++ version (although cross-polination of patches was appreciated). @antirez 's version is in C. C++ is easier to maintain than C, but there are valid reasons someone may want to use C, primarily I guess on codebases that have no existing C++ .

But I still think this is a good idea. I ended up writing this one in modern C++:

https://github.com/ericcurtin/readline.cpp

My advice would be use linenoise if you want something written in C, readline.cpp if you want something written in C++ although there are other options for both.

I'm gonna retire/archive linenoise.cpp .

it's essentially unmaintained, I'm offering to change that.

There have been some works since, especially the CVE #240 that got merged to your downstream project.

So now I'm unsure if this PR actually caused harm to the original project or not.

[antirez]

Hello, utf-8 is work in progress, I'll update this library soon. Over the years, linenoise received a few updates, even significant. I just believe even not fast moving software is good software sometimes :) But UTF-8 is needed, and will be integrated. Closing this.