Proposal: provide a possibility of passing custom zoom factor to renderer (not graphics)#244
Open
nicky1038 wants to merge 1 commit intoanvaka:masterfrom
Open
Proposal: provide a possibility of passing custom zoom factor to renderer (not graphics)#244nicky1038 wants to merge 1 commit intoanvaka:masterfrom
nicky1038 wants to merge 1 commit intoanvaka:masterfrom
Conversation
…erer (not graphics) Before this proposal one could pass custom factor to 'graphics.scale' BUT calling this method directly causes: - no redendering; - no raising 'scale' event by renderer; - no changing 'transform.scale'. Of course these actions could be done later in third party code, but in this case it should just repeat the existing 'renderer.scale' method. It's better to allow developers not to do so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this proposal one could pass a custom
factorparameter tographics.scalemethod BUT calling it directly causes:scaleevent by renderer;transform.scale.Of course these actions could be done later in third party code, but in this case it should just repeat the existing
renderer.scalemethod. It's better to allow developers not to do so.