repair: remove CMR block_id requests #624
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
force-pushed
the
dmr-repair
branch
3 times, most recently
from
16b0a33 to
e4aaaa1
Compare
AshwinSekar
force-pushed
the
dmr-repair
branch
from
e4aaaa1 to
b9c8159
Compare
AshwinSekar
commented
Dec 5, 2025
| // Block Id based variants. Note that unlike the above requests, these require that the responder has | ||
| // the full block in order to respond. | ||
| /// Requesting `MAX_ORPHAN_REPAIR_RESPONSES` parent shreds for the specific block ID | ||
| OrphanForBlockId(Slot, Hash), |
Contributor
Author
There was a problem hiding this comment.
will be replacing these with the ones in the paper
AshwinSekar
commented
Dec 5, 2025
|
|
||
| /// Fulfills orphan requests from the turbine column only. This predates block id logic and is left for compatability | ||
| /// with TowerBFT. This variant will respond to requests even if the block has not been fully ingested. | ||
| fn run_orphan_turbine_only( |
Contributor
Author
There was a problem hiding this comment.
this is copied back into run_orphan in repair_handler.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We added some block id repair requests based on the assumption that we were using CMR.
With DMR these requests are not necessary.
Summary of Changes
Remove them except for shred for block id.
Next PR will add getFecSetCountWithParent & getFecSetRoot instead to match what we have in the paper.