fix(packages/react): allow single transaction to wallet modify and sign hook

[datasalaryman]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 52fa702

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 42 packages

Name	Type
@solana/signers	Minor
@solana/react	Minor
@solana/kit	Minor
@solana/accounts	Minor
@solana/addresses	Minor
@solana/assertions	Minor
@solana/codecs-core	Minor
@solana/codecs-data-structures	Minor
@solana/codecs-numbers	Minor
@solana/codecs-strings	Minor
@solana/codecs	Minor
@solana/compat	Minor
@solana/errors	Minor
@solana/fast-stable-stringify	Minor
@solana/functional	Minor
@solana/instruction-plans	Minor
@solana/instructions	Minor
@solana/keys	Minor
@solana/nominal-types	Minor
@solana/offchain-messages	Minor
@solana/options	Minor
@solana/programs	Minor
@solana/promises	Minor
@solana/rpc-api	Minor
@solana/rpc-graphql	Minor
@solana/rpc-parsed-types	Minor
@solana/rpc-spec-types	Minor
@solana/rpc-spec	Minor
@solana/rpc-subscriptions-api	Minor
@solana/rpc-subscriptions-channel-websocket	Minor
@solana/rpc-subscriptions-spec	Minor
@solana/rpc-subscriptions	Minor
@solana/rpc-transformers	Minor
@solana/rpc-transport-http	Minor
@solana/rpc-types	Minor
@solana/rpc	Minor
@solana/subscribable	Minor
@solana/sysvars	Minor
@solana/transaction-confirmation	Minor
@solana/transaction-messages	Minor
@solana/transactions	Minor
@solana/webcrypto-ed25519-polyfill	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[datasalaryman]

@mcintyre94 could I ask for what you'd prefer here? I'm looking for a way to pass a single transaction to the modifyAndSign function. Would you rather the API:

1. allow for both a single transaction and array of transactions? (this PR)
2. have a separate function to pass just one transaction to sign?

[mcintyre94]

Can you explain the use case here a bit? I'm not sure i see the benefit because the output is still an array. For the app to make its input an array should be trivial, I'd expect the complexity here comes from handling an output array.

I think if we did this then it would make more sense to mirror the signers API with single transaction versions, that take a single transaction as both input and output. Though that would definitely restrict the API a bit, if it makes sense for some signer to return multiple transactions from a single transaction input for example. I'm not sure it'd be better than what we have now.

It'd be good to understand the use case better first though. And would be curious if @lorisleiva has any thoughts on this too!

[sidhys]

Chiming in: like mcintyre94 said, dealing with output is the actual issue - have you considered something along the lines of modifyAndSignTransactions([transaction])?