-
Notifications
You must be signed in to change notification settings - Fork 13
feat: implement consolidated benchmarking suite #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cpubot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should measure serialize as well?
we can do same pattern for it , ill add serialization benchmarks |
cpubot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, work! Thanks
seems like benchmarks cannot run under miri because they use criterion which does file I/O and process spawning know Benchmarks should NOT be run with miri ? |
Right, they shouldn't run with miri |
ig we need updated the CI workflow to exclude benchmarks from miri (--lib --bins instead of --all-targets). should be good now sounds good to u ? |
Yep, sounds good |
cc @cpubot