Skip to content

Conversation

@TanmayDhobale
Copy link
Contributor

@TanmayDhobale TanmayDhobale commented Nov 28, 2025

cc @cpubot

@TanmayDhobale TanmayDhobale requested a review from cpubot December 3, 2025 18:24
Copy link
Collaborator

@cpubot cpubot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should measure serialize as well?

@TanmayDhobale
Copy link
Contributor Author

Perhaps we should measure serialize as well?

we can do same pattern for it , ill add serialization benchmarks

@TanmayDhobale TanmayDhobale requested a review from cpubot December 3, 2025 19:24
cpubot
cpubot previously approved these changes Dec 3, 2025
Copy link
Collaborator

@cpubot cpubot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, work! Thanks

@TanmayDhobale
Copy link
Contributor Author

Nice, work! Thanks

seems like benchmarks cannot run under miri because they use criterion which does file I/O and process spawning know

Benchmarks should NOT be run with miri ?

@cpubot
Copy link
Collaborator

cpubot commented Dec 4, 2025

Nice, work! Thanks

seems like benchmarks cannot run under miri because they use criterion which does file I/O and process spawning know

Benchmarks should NOT be run with miri ?

Right, they shouldn't run with miri

@TanmayDhobale
Copy link
Contributor Author

Nice, work! Thanks

seems like benchmarks cannot run under miri because they use criterion which does file I/O and process spawning know
Benchmarks should NOT be run with miri ?

Right, they shouldn't run with miri

ig we need updated the CI workflow to exclude benchmarks from miri (--lib --bins instead of --all-targets). should be good now sounds good to u ?

@cpubot
Copy link
Collaborator

cpubot commented Dec 4, 2025

ig we need updated the CI workflow to exclude benchmarks from miri (--lib --bins instead of --all-targets). should be good now sounds good to u ?

Yep, sounds good

@cpubot cpubot merged commit 821f5cb into anza-xyz:master Dec 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants