Skip to content

Proxy Linkspan through the link - #743

Draft
yasithdev wants to merge 6 commits into
apache:masterfrom
yasithdev:interactive
Draft

yasithdev wants to merge 6 commits into
apache:masterfrom
yasithdev:interactive

Conversation

@yasithdev

@yasithdev yasithdev commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor
  • /processes/{id}/linkspan/… proxies Linkspan's API over the link.
  • HTTP and WebSocket.
  • Replaces /processes/{id}/jupyter/….
  • Jupyter baseUrl is now …/linkspan/api/v1/forward/{port}/.
  • Linkspan forwards TCP only.
  • Airavata sends HTTP for forward/{port}/… to that port over the link.
  • Same Jupyter token.
  • 502 while not linked.
  • SUBMITTED becomes RUNNING when Linkspan dials.

@DImuthuUpe

Copy link
Copy Markdown
Contributor

@yasithdev can you fix merge conflicts?

@DImuthuUpe DImuthuUpe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yasithdev I can see some very important framework level fixes and interactive connection integration bundled in this PR. Can you try to make this 2 - 3 smaller PR with framework level fixes first and then linkspan integration later?

Comment thread internal/ssh/interactive.go Outdated
case <-s.authWaitSignal:
case <-ctx.Done():
return nil, ctx.Err()
return nil, context.Cause(ctx)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yasithdev What is the reason for this change?

Comment thread internal/ssh/interactive.go Outdated
// banner and connection are set before the auth is published and never change, so
// they need no lock. connection is the client connection the prompts go back to.
banner string
connection string

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need another connection string?

OwnerID string `gorm:"column:user_id;type:varchar(255);not null;index" json:"userId"`
CreatedAt int64 `gorm:"column:created_at;type:bigint;not null" json:"createdAt"`
CurrentProcessID string `gorm:"column:current_process_id;type:varchar(36);not null" json:"currentProcessId"`
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the same process object instead of session?

@yasithdev
yasithdev force-pushed the interactive branch 2 times, most recently from 0fcd99b to ff6504a Compare November 8, 2026 23:48
@yasithdev
yasithdev marked this pull request as draft November 8, 2026 23:48
@yasithdev yasithdev changed the title Interactive sessions via Linkspan Reach batch jobs via Linkspan Nov 8, 2026
@yasithdev

Copy link
Copy Markdown
Contributor Author

Hi @DImuthuUpe, I raised #751-#755 by breaking down this PR as you suggested.

@yasithdev
yasithdev force-pushed the interactive branch 5 times, most recently from 85c6562 to 682040b Compare November 9, 2026 22:11
@yasithdev
yasithdev changed the base branch from master to jupyter-ui-poc November 10, 2026 01:37
@yasithdev
yasithdev force-pushed the interactive branch 2 times, most recently from 1305b17 to 3849f91 Compare November 10, 2026 16:19
@yasithdev yasithdev changed the title Reach batch jobs via Linkspan Reach job ports through the link Nov 10, 2026
@yasithdev yasithdev changed the title Reach job ports through the link Proxy Linkspan through the link Nov 10, 2026
@yasithdev
yasithdev changed the base branch from jupyter-ui-poc to master November 11, 2026 06:16
@yasithdev
yasithdev force-pushed the interactive branch 5 times, most recently from 924d02c to bdd2c6d Compare November 11, 2026 21:13
@yasithdev
yasithdev force-pushed the interactive branch 6 times, most recently from b90d210 to 1a654f6 Compare November 15, 2026 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants