feat(go/adbc/driver/flightsql): handle is_update in prepared stmts#4161
feat(go/adbc/driver/flightsql): handle is_update in prepared stmts#4161ennuite wants to merge 4 commits intoapache:mainfrom
Conversation
…reatePreparedStatementResult
|
I'm unsure of which component to use given that I touched 3 different ones: It's my first PR in this codebase and I'm not very familiar with Go. I would appreciate a review not only on the content but also on style. I'm available for improving this as requested. It's not yet in a state where I feel like it's ready to merge, although it is fine as a PoC. Things I want to improve:
Question: I added a logger in Python, but I don't see logging being used anywhere else. I would like to know your opinion on log statements in this codebase. |
|
This PR is not an individual piece of work. It requires changes in Arrow-Go and the main repo. |
lidavidm
left a comment
There was a problem hiding this comment.
Don't make any Python changes. It should be handled entirely in the driver.
@lidavidm I thought about that and it would definitely be much easier. However, do we want this in ADBC Go? My understanding is that, in ADBC Go, queries that generate result sets go via |
|
Yes, that should be handled properly. It'll simply return an empty resultset. |
|
I see you already approved. I will still add tests tomorrow, but the feature work is finished. After I add the tests, if you agree, I think it's time to put the spec change to a vote. |
AI Disclaimer
This change was created with AI assistance (Augment Code). All lines were manually reviewed by a human. The output is not copyrightable subject matter.
Closes #4074