Add union to opaque comparisons #8896
Open
+514
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendlymatthew
force-pushed
the
friendlymatthew/union-to-opaque
branch
from
5f9ca9b to
35ec44d
Compare
Contributor
Author
|
cc @alamb (sorry for the constant pinging I feel) |
46 tasks
Contributor
|
No problem @friendlymatthew -- I'll put it on my review queue I am currently putting my arrow-rs focus on getting the release out. I'll probably have more time for reviews next week It looks like there are several CI failures with this PR |
friendlymatthew
force-pushed
the
friendlymatthew/union-to-opaque
branch
from
35ec44d to
e8a2b1e
Compare
friendlymatthew
force-pushed
the
friendlymatthew/union-to-opaque
branch
from
e8a2b1e to
9b30e9a
Compare
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This PR implements comparison logic for Union arrays against opaque (non-union) arrays in the
ordkernelWhen comparing a union to an opaque array, the comparison first checks if the union's type id matches the opaque array's type, then compares the actual values if types align. This provides a consistent ordering where union variants are ordered by their type id relative to the opaque type
Notes about this PR
Please review from the second commit. The first commit being #8838