GH-48062: [C++] Fix null pointer dereference in MakeExecBatch #48063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
arrow::compute::MakeExecBatchfunction callsDataType::id()onpartial.type()which could be a null pointer whenpartialis a datum representing a table.MakeExecBatchfails to check for this and thus null pointer dereference indeed happen.What changes are included in this PR?
This patch adds a simple check in
MakeExecBatchbefore callingDataType::id()to make sure it won't gets called on a null pointer.Are these changes tested?
Yes. This patch updates the unit test
ExpressionUtils.MakeExecBatchand includes a case that callsMakeExecBatchwith a table.Are there any user-facing changes?
No.
This PR indeed resolve a crash problem, but I'm not quite sure whether this should be classified as a "critical fix".
Resolve #48062 .