GH-48089: [C++][Parquet] Read statistics and other metadata when fuzzing #48090
Conversation
github-actions
bot
added
awaiting review
|
@github-actions crossbow submit fuzz |
|
Revision: b663073 Submitted crossbow builds: ursacomputing/crossbow @ actions-ed4742dbd2
|
pitrou
force-pushed
the
gh48089-pq-fuzz-read-metadata
branch
from
b663073 to
a1d2895
Compare
|
@github-actions crossbow submit fuzz |
|
Revision: a1d2895 Submitted crossbow builds: ursacomputing/crossbow @ actions-e898f807d8
|
pitrou
force-pushed
the
gh48089-pq-fuzz-read-metadata
branch
from
a1d2895 to
2ec30dd
Compare
|
@github-actions crossbow submit fuzz |
|
Revision: 2ec30dd Submitted crossbow builds: ursacomputing/crossbow @ actions-ce7ba541c2
|
|
@wgtmac @mapleFU @adamreeve @EnricoMi Are you available to take a look at this? |
| throw ParquetException("bloom_filter_length less than 0"); | ||
| } | ||
| if (*bloom_filter_length + *bloom_filter_offset > file_size) { | ||
| if (*bloom_filter_length > file_size - *bloom_filter_offset) { |
There was a problem hiding this comment.
Why calling this ? Would add overflows
There was a problem hiding this comment.
Yes, it could. The alternative is to call AddWithOverflow.
github-actions
bot
added
awaiting committer review
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 934554d. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
2 participants
Rationale for this change
Some parts of the Parquet C++ codebase are not fuzzed yet, since they are not exercised in the fuzz target.
What changes are included in this PR?
Add the following tasks when fuzzing an input:
Are these changes tested?
By OSS-Fuzz.
Are there any user-facing changes?
No.