[AURON #1873] Add unified join BuildSide abstraction for cross-spark-version compatibility #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yew1eb
force-pushed
the
AURON_1873
branch
3 times, most recently
from
fea0cd0 to
a396fca
Compare
yew1eb
changed the title
yew1eb
force-pushed
the
AURON_1873
branch
12 times, most recently
from
16b9c15 to
09ff783
Compare
…park-version compatibility
richox
approved these changes
Jan 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a unified JoinBuildSide abstraction to support cross-Spark-version compatibility by consolidating multiple Spark-version-specific build side types (BuildSide, BroadcastSide, org.apache.spark.sql.execution.joins.BuildSide, org.apache.spark.sql.catalyst.optimizer.BuildSide) into a single abstraction.
Changes:
- Created a new
JoinBuildSidesobject containing a sealed traitJoinBuildSidewithJoinBuildLeftandJoinBuildRightcase objects - Removed duplicate build side type definitions from
NativeShuffledHashJoinBaseandNativeBroadcastJoinBase - Added
getJoinBuildSidemethod toShimswith version-specific implementations to convert Spark's build side types to the unified abstraction
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| JoinBuildSides.scala | New file defining the unified JoinBuildSide trait and its implementations |
| NativeShuffledHashJoinBase.scala | Removed local BuildSide definitions, updated to use unified JoinBuildSide |
| NativeBroadcastJoinBase.scala | Removed local BroadcastSide definitions, updated to use unified JoinBuildSide |
| Shims.scala | Added abstract getJoinBuildSide method and updated method signatures to use JoinBuildSide |
| AuronConverters.scala | Simplified join conversion logic by using new getJoinBuildSide shim method, removed unnecessary imports and pattern matching |
| AuronConvertStrategy.scala | Updated joinSmallerSideTag type from BuildSide to JoinBuildSide |
| NativeShuffledHashJoinExecProvider.scala | Updated imports and conversions to use unified JoinBuildSide |
| NativeBroadcastJoinExec.scala | Updated imports and conversions to use unified JoinBuildSide |
| ShimsImpl.scala | Implemented getJoinBuildSide with version-specific logic for Spark 3.0 and 3.1+ |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1873
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?