Skip to content

Conversation

@yew1eb
Copy link
Contributor

@yew1eb yew1eb commented Jan 11, 2026

Which issue does this PR close?

Closes #1879

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

How was this patch tested?


<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we still need checkstyle? Because we have used spotless-maven-plugin.

auron/pom.xml

Lines 488 to 507 in 3264372

<artifactId>spotless-maven-plugin</artifactId>
<version>${spotless.plugin.version}</version>
<configuration>
<java>
<palantirJavaFormat />
<removeUnusedImports />
<licenseHeader>
<file>${maven.multiModuleProjectDirectory}/dev/license-header</file>
</licenseHeader>
</java>
<scala>
<scalafmt>
<version>${scalafmtVersion}</version>
<file>${maven.multiModuleProjectDirectory}/scalafmt.conf</file>
<scalaMajorVersion>${scalaVersion}</scalaMajorVersion>
</scalafmt>
<licenseHeader>
<file>${maven.multiModuleProjectDirectory}/dev/license-header</file>
</licenseHeader>
</scala>

Copy link
Contributor Author

@yew1eb yew1eb Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add Checkstyle to complement Spotless — while both serve as quality gates, Spotless focuses on format consistency (auto-fixable) and Checkstyle on semantic style rules (readability/maintainability) that Spotless doesn’t address. This dual setup ensures comprehensive code standard enforcement, which is critical for project quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add maven checkstyle plugin

2 participants