Fix PerformanceTests HadoopFormat job#38292
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issues with the PerformanceTests HadoopFormat job by adjusting how AutoValue classes are handled within the BigQueryIO translation layer. By explicitly referencing the generated AutoValue classes and suppressing specific Error Prone warnings, the changes ensure better compatibility and stability for the affected pipeline components. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
| def disabledChecks = [ | ||
| // TODO(https://github.com/apache/beam/issues/20955): Enable errorprone checks | ||
| "AutoValueImmutableFields", | ||
| "AutoValueSubclassLeaked", |
There was a problem hiding this comment.
Can we just use SuppressWarnings instead like
There was a problem hiding this comment.
I thought the safest way is to revert this part as it was previously
There was a problem hiding this comment.
I think here the suggestion is to not add "AutoValueSubclassLeaked" suppression back to BeamModulePlugins, and we can revert the change (including "BigQueryIOTranslation.java") then add "SuppressWarnings" annotations in the specific places
There was a problem hiding this comment.
Yeah - that should get us back to green, but allows us to keep the warning for future code
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Thanks! |
Fixes #33393
Successful run: https://github.com/apache/beam/actions/runs/25052974959
Reverts #38256 partially (AutoValueSubclassLeaked)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.