Repository navigation
chore: ci - Scalpel ignores root-level files that do not affect the build - #29636
Merged
Merged
Conversation
…uild Since Scalpel 0.5.0 (#29611) a changed root-level file that no module owns triggers a full build, even with an empty fullBuildTriggers, and incremental-build.sh then drops Scalpel's module list. Add the root-level doc and repository files (CLAUDE.md, AGENTS.md, README.md, Jenkinsfile*, ...) to -Dscalpel.excludePaths. mvnw, mvnw.cmd and pom.xml still trigger a full build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepares the Scalpel 0.5.0 bump (#29611).
In Scalpel 0.5.0 a changed root-level file that no module owns (for example
CLAUDE.md) triggers a full build (maveniverse/scalpel#229,ModuleMapper), even with our empty-Dscalpel.fullBuildTriggers=.incremental-build.shreadsfullBuildTriggeredas a Scalpel failure and drops Scalpel's module list. A PR that touchesCLAUDE.mdalongside a POM change would then lose the downstream modules that Scalpel found.This PR adds the root-level files that do not affect the build to
-Dscalpel.excludePaths, next to.github/**:AGENTS.md, CLAUDE.md, CONTRIBUTING.md, README.md, SECURITY.md, KEYS, LICENSE.txt, NOTICE.txt, doap.rdf, Jenkinsfile*, .asf.yaml, .gitattributes, .gitignore, .gitmodules, .sdkmanrc, jbang-catalog.json.mvnw,mvnw.cmdandpom.xmlare left out on purpose, so a change to them still triggers a full build./into{p,**/p}, so these names also match inside modules, for exampledsl/camel-jbang/camel-jbang-core/CLAUDE.md. That only hides the file from Scalpel: the file-path step of the script still adds the module of such a file to the build.glob:PathMatcher, the way Scalpel 0.5.0'sPathFiltersbuilds them:CLAUDE.md,Jenkinsfile.jdk26,.github/workflows/x.yml;pom.xml,mvnw,parent/pom.xml,.mvn/extensions.xmland module sources.CI-ARCHITECTURE.mddocuments the setting.🤖 Generated with Claude Code
https://claude.ai/code/session_016Y4dDiMc7mxmdVoQiGSMh8