Linstor fix host picking

[rp-]

Description

Before it was possible that a Host was picked for the primary storage
that was not even part of cluster, now we only consider hosts
from either the same cluster or same zone depending on primary storage
settings.

Also improve cleanup code on copyAsync operations.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Hyperconverge and non hyperconverge Linstor cluster tested.

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.17%. Comparing base (d26122b) to head (1e9040f).

Files with missing lines	Patch %	Lines
...tore/driver/LinstorPrimaryDataStoreDriverImpl.java	0.00%	43 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #12047      +/-   ##
============================================
- Coverage     16.18%   16.17%   -0.01%     
+ Complexity    13305    13299       -6     
============================================
  Files          5657     5657              
  Lines        498459   498465       +6     
  Branches      60492    60491       -1     
============================================
- Hits          80694    80651      -43     
- Misses       408783   408831      +48     
- Partials       8982     8983       +1     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.03% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15718

[DaanHoogland]

clgtm