COLLECTIONS-767 MapBuilder class to decide among various types of Maps#188
COLLECTIONS-767 MapBuilder class to decide among various types of Maps#188Amita-Pradhan wants to merge 3 commits intoapache:masterfrom
Conversation
kinow
left a comment
There was a problem hiding this comment.
I am used to choosing a map based on what I need, so not sure if I would use it immediately.
But looks very interesting at first. Needs a JIRA issue too (which is used for the changelog too).
Will take another look later. But fter a cursory look, code looks good.
Thanks for your contribution!
Bruno
src/test/java/org/apache/commons/collections4/MapBuilderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/commons/collections4/MapBuilderTest.java
Outdated
Show resolved
Hide resolved
e2abfce to
b5cc1de
Compare
|
@kinow , @garydgregory , any reason not to merge this or should we just close the pull request? |
If it were just me, I would close it. I feel I am better served knowing what the JDK offers , what Commons Collection offers, and the difference. It feels like a solution in search of a problem. I don't see using this in code I write FWIW. |
No description provided.