add override functions for accepting suppliers.#586
add override functions for accepting suppliers.#586XenoAmess wants to merge 1 commit intoapache:masterfrom
Conversation
|
@garydgregory please have a look and give some opinions. just like our good old days, sigh. |
|
Hello @XenoAmess -1: I won't spend time reviewing this new code without unit tests. Instead, I'll spend my time writing this: Tests in PRs are important: They show intent, edge cases, and expected failures. A contributor must show the intended usage of the code, without an application, unit tests stand in for these call sites. Asking a maintainer (me) to spend their time when you did not spend your time doing the basics it not an equitable trade-off. |
sounds reasonable. |
it be needed as something like: query several mongo collections one by one, etc.
992c5e0 to
0dbf285
Compare
|
@garydgregory unit test added. please have a look |
it be needed as something like:
query several mongo collections one by one, etc.
t is useful, yeah, at lease my job needs it now...
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.