Skip to content

[IO-886] Fixed incorrect regular expression in PathUtils.RelativeSortedPaths.extractKey(String, String)#828

Merged
garydgregory merged 1 commit intoapache:masterfrom
peterdemaeyer:IO-886-regex-replace
Feb 14, 2026
Merged

[IO-886] Fixed incorrect regular expression in PathUtils.RelativeSortedPaths.extractKey(String, String)#828
garydgregory merged 1 commit intoapache:masterfrom
peterdemaeyer:IO-886-regex-replace

Conversation

@peterdemaeyer
Copy link
Contributor

Fixed incorrect regular expression in replaceAll by replacing it with a plain replace.

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory
Copy link
Member

Hello @peterdemaeyer

Thank you for the PR.

This PR is missing a unit test that fails when the main side of the tree is not applied, which is just asking for a regression IMO.

@garydgregory
Copy link
Member

garydgregory commented Feb 14, 2026

I looked at this again and it makes sense; building...

@garydgregory garydgregory changed the title IO-886 Fixed incorrect regular expression [IO-886] Fixed incorrect regular expression Feb 14, 2026
@garydgregory
Copy link
Member

The Jira ticket is https://issues.apache.org/jira/browse/IO-886

@garydgregory garydgregory merged commit 3cc801f into apache:master Feb 14, 2026
21 checks passed
@garydgregory garydgregory changed the title [IO-886] Fixed incorrect regular expression [IO-886] Fixed incorrect regular expression in PathUtils.extractKey() Feb 14, 2026
@garydgregory garydgregory changed the title [IO-886] Fixed incorrect regular expression in PathUtils.extractKey() [IO-886] Fixed incorrect regular expression in PathUtils.RelativeSortedPaths.extractKey(String, String) Feb 14, 2026
garydgregory added a commit that referenced this pull request Feb 14, 2026
PathUtils.RelativeSortedPaths.extractKey(String, String). #828

Javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants