chore(core): remove unused diagram module - #2355
Merged
andygrove merged 1 commit intoAug 25, 2026
Merged
Conversation
NoahKusaba
marked this pull request as draft
August 22, 2026 17:46
NoahKusaba
marked this pull request as ready for review
August 22, 2026 17:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
ballista_core::diagramhas no callers anywhere in the repository. It was superseded byscheduler/src/state/execution_graph_dot.rsand the CLI's job DOT popup, but stayedpublicly exported and carried two
#[allow(deprecated)]attributes to keep a deprecatedCoalesceBatchesExecimport compiling.What changes are included in this PR?
ballista/core/src/diagram.rs(145 lines).pub mod diagram;declaration fromballista/core/src/lib.rs.Are there any user-facing changes?
Yes.
ballista_core::diagramis removed from the public API ofballista-core. It has noin-tree users, but this is a breaking change for any downstream consumer — may warrant the
api changelabel.