perf(scheduler): stop re-encoding the session config for every task - #2358
Open
NoahKusaba wants to merge 1 commit into
Open
perf(scheduler): stop re-encoding the session config for every task#2358NoahKusaba wants to merge 1 commit into
NoahKusaba wants to merge 1 commit into
Conversation
NoahKusaba
force-pushed
the
perf/hoist-task-session-props
branch
from
August 23, 2026 16:59
b4f787a to
8025374
Compare
NoahKusaba
force-pushed
the
perf/hoist-task-session-props
branch
from
August 23, 2026 17:05
8025374 to
63421e8
Compare
Dandandan
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Release build, 32-task batch, 200 iterations, measured on
prepare_multi_task_definitionend to end:What changes are included in this PR?
Encode the session config once per task batch instead of once per task, cloning it into each task's definition.