Chore: to_json unit/benchmark tests #3011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 768b3e9.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3011 +/- ##
============================================
+ Coverage 56.12% 59.58% +3.45%
- Complexity 976 1379 +403
============================================
Files 119 167 +48
Lines 11743 15497 +3754
Branches 2251 2573 +322
============================================
+ Hits 6591 9234 +2643
- Misses 4012 4966 +954
- Partials 1140 1297 +157 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| customStrings: Seq[String] = Seq.empty, | ||
| maxStringLength: Int = 8) | ||
| maxStringLength: Int = 8, | ||
| generateInfinity: Boolean = true) |
Contributor
Author
There was a problem hiding this comment.
Comet to_json does not support NaN, +Infinity, -Infinity values for numeric types.
Member
|
@kazantsev-maksim could you merge latest from main to disable the failing test |
Contributor
Author
|
Thanks @andygrove , I've merged it with master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of: #2955
Rationale for this change
What changes are included in this PR?
How are these changes tested?