fix: [iceberg] reduce granularity of metrics updates in IcebergFileStream #3050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
Profiling of Iceberg table scans revealed significant overhead from timer calls (
clock_gettime) in theIcebergFileStreamstate machine.What changes are included in this PR?
Move
baseline.record_poll()from inside the state machine (where it wrapped every batch poll) to the top-levelpoll_next()method, matching the DataFusionFileStreampattern:record_poll()in theReadingstaterecord_poll()call at the top-levelpoll_next()How are these changes tested?
Existing tests.